WebGPU: Introduce Fat Points #26930

WestLangley · 2023-10-09T20:30:21Z

As suggested in #25697 (comment).

Based on #11349. A "fat point" sized in pixel units is just a "fat line" of zero length.

Note, these "fat" points are sized in pixel units. This is different than the THREE.Points implementation.

//

So, what features do we want to support?

How should this be integrated into Core?

In particular, what should be the API?

Mugen87 · 2023-10-10T10:41:34Z

TBH, I'm not really a fan of the Fat* syntax. I would call the class InstancedSprite (and InstancedSpriteGeometry and InstancedSpriteMaterial).

Mugen87 · 2023-10-10T11:26:49Z

Sidenote: At some point we should maybe rename examples like webgl_lines_fat to webgl_lines_wide or something similar.

WestLangley · 2023-10-10T14:56:12Z

I would call the class InstancedSprite

But these are not sprites. They are points, sized in pixels. When re-implemented in TSL, they would replace the single-pixel points rendered by WebGPURenderer.

Instanced sprites have a map, are sized in world units, can be size-attenuated, and can be rotated.

I am inclined to think we are talking about two different things.

I'm not really a fan of the Fat* syntax.

That's fine. Different nomenclature can be used.

Mugen87 · 2023-10-10T14:58:25Z

We can also call them InstancedPoints. I think we originally did want to use the "points" term because they are not based on the points primitive.

Mugen87 · 2023-10-11T11:01:58Z

Regarding #25697 (comment):

With this implementation, is the point size now consistent when changing the renderer's pixel ratio?

WestLangley · 2023-10-11T19:32:24Z

With this implementation, is the point size now consistent when changing the renderer's pixel ratio?

The user should not have to worry about the device pixels.

pointWidth here is in CSS Pixels, and the point size is invariant to window.devicePixelRatio.

Mugen87 · 2023-10-11T19:43:06Z

pointWidth here is in CSS Pixels, and the point size is invariant to window.devicePixelRatio.

That is good since it solves one issue with previous point primitive rendering.

examples/jsm/nodes/materials/FatPointsNodeMaterial.js

WestLangley · 2023-10-11T23:05:21Z

WebGPURenderer is now supported. Many thanks to @aardgoose for #26704.

The "Fat Points" nomenclature can be changed.

examples/jsm/nodes/accessors/FatPointsMaterialNode.js

examples/jsm/nodes/core/PropertyNode.js

LeviPesin · 2023-10-12T09:15:04Z

examples/webgpu_points_fat.html

+			import { OrbitControls } from 'three/addons/controls/OrbitControls.js';
+
+			import { FatPoints } from 'three/addons/points/FatPoints.js';
+			//import { FatPointsNodeMaterial } from 'three/addons/points/FatPointsNodeMaterial.js'; // why not this, instead?


You can actually use just FatPointsMaterial and it would be auto-converted to FatPointsNodeMaterial by WebGPURenderer based on its name.

Here I just meant that you can import just the FatPointsMaterial instead of FatPointsNodeMaterial and it should work exactly the same.
For background I believe setting scene.background = THREE.Color( 0x222222 ) should also work just fine as scene.backgroundNode = color( 0x222222 ). So basically using the same code as for WebGL should work 🙂

I think we no longer need FatPointsMaterial. My intention is to remove it. (I just wanted to get its shader to work correctly before attempting the Node version.)

You can actually use just FatPointsMaterial and it would be auto-converted to FatPointsNodeMaterial

It does render, but the vertex colors are not honored.

Assuming that will be fixed, would it be preferable to retain FatPointsMaterial (in glsl) and remove FatPointsNodeMaterial?

ping @sunag @LeviPesin

If the main scope is WebGPURenderer, I vote yes.

It's great to see NodeMaterial saved lines of code in relation to the same material created in ShaderMaterial, with the advantages that each "uniform" is a channel for a procedural node.

For background I believe setting scene.background = THREE.Color( 0x222222 ) should also work just fine as scene.backgroundNode = color( 0x222222 ).

For WebGPURenderer (both backends), it appears

scene.background = new THREE.Color( 0xff0000 ); // does not honor viewport/scissor scene.backgroundNode = color( 0xff0000 ); // honors viewport/scissor

scene.background = new THREE.Color( 0xff0000 ); // does not honor viewport/scissor

Could this be happening there because scene.backgroundNode overrides the scene.background settings?
I tested it in webgpu_lines_fat replacing all scene.backgroundNode to null and work. (or just remove all scene.backgroundNode assigns)

@sunag For me, the background color of the inset view extends to the entire screen when scene.background is used in WebGPURenderer.

scene.background = new THREE.Color( 0xff0000 ); // does not honor viewport/scissor

Could this be happening there because scene.backgroundNode overrides the scene.background settings? I tested it in webgpu_lines_fat replacing all scene.backgroundNode to null and work. (or just remove all scene.backgroundNode assigns)

Setting the background color using the clear color doesn't work in the same way as WebGLRenderer. The scissor area does not constrain the region cleared.

/ping @sunag @LeviPesin See comment by @aardgoose .

examples/jsm/nodes/materials/FatPointsNodeMaterial.js

Mugen87 · 2023-10-14T08:39:55Z

Please remove the Fat* syntax though. I vote for InstancedPoints*.

WestLangley · 2023-10-14T16:57:49Z

@sunag Let's also consider calling them Points, and making this transparent to the user. I think we should have a discussion about this.

mrdoob · 2023-10-26T08:50:23Z

@sunag Let's also consider calling them Points, and making this transparent to the user. I think we should have a discussion about this.

I vote for this too 👍

We could, instead, introduce BasicPoints to allow people use the GL_POINTS / point-list code path?

Introduce Fat Points

d63257e

WestLangley marked this pull request as draft October 9, 2023 20:33

Mugen87 added this to the r??? milestone Oct 10, 2023

Introduce FatPointsNodeMaterial

0b79919

github-advanced-security bot found potential problems Oct 11, 2023

View reviewed changes

examples/jsm/nodes/materials/FatPointsNodeMaterial.js Fixed Show fixed Hide fixed

examples/jsm/nodes/materials/FatPointsNodeMaterial.js Fixed Show fixed Hide fixed

examples/jsm/nodes/materials/FatPointsNodeMaterial.js Fixed Show fixed Hide fixed

WestLangley added 2 commits October 11, 2023 18:30

Enable damping

2a1c60e

Clean up

a7f384d

github-advanced-security bot found potential problems Oct 11, 2023

View reviewed changes

examples/jsm/nodes/materials/FatPointsNodeMaterial.js Fixed Show fixed Hide fixed

Clean up

6cf85a3

github-advanced-security bot found potential problems Oct 11, 2023

View reviewed changes

examples/jsm/nodes/materials/FatPointsNodeMaterial.js Fixed Show fixed Hide fixed

Clean up

8e1064f

Clean up

c53add5

LeviPesin reviewed Oct 12, 2023

View reviewed changes

examples/jsm/nodes/accessors/FatPointsMaterialNode.js Show resolved Hide resolved

LeviPesin reviewed Oct 12, 2023

View reviewed changes

examples/jsm/nodes/core/PropertyNode.js Show resolved Hide resolved

LeviPesin reviewed Oct 12, 2023

View reviewed changes

sunag reviewed Oct 13, 2023

View reviewed changes

examples/jsm/nodes/materials/FatPointsNodeMaterial.js Show resolved Hide resolved

WestLangley added 2 commits October 13, 2023 22:36

Delete FatPointsMaterial

3824a18

Clean up

26e3419

WestLangley changed the title ~~Fat Points: Proof of Concept~~ WebGPU: Introduce Fat Points Oct 14, 2023

WestLangley added 2 commits October 13, 2023 22:48

Add screenshot

136db0a

Updated files

277c4af

WestLangley marked this pull request as ready for review October 14, 2023 03:15

WestLangley modified the milestones: r???, r158 Oct 14, 2023

sunag merged commit c44c4ec into mrdoob:dev Oct 14, 2023
19 checks passed

WestLangley deleted the dev-fat_points branch October 14, 2023 16:44

sunag mentioned this pull request Oct 14, 2023

WebGPURenderer: Rename FatPoints to InstancedPoints #26965

Merged

This was referenced Oct 15, 2023

Nodes: Update PropertyNode exports #26975

Merged

Nodes: Merge *MaterialNode into singular MaterialNode, fix exports, some cleanup #26976

Merged

Methuselah96 mentioned this pull request Oct 22, 2023

r158 three-types/three-ts-types#631

Closed

16 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

WebGPU: Introduce Fat Points #26930

WebGPU: Introduce Fat Points #26930

WestLangley commented Oct 9, 2023 •

edited

Mugen87 commented Oct 10, 2023

Mugen87 commented Oct 10, 2023 •

edited

WestLangley commented Oct 10, 2023 •

edited

Mugen87 commented Oct 10, 2023

Mugen87 commented Oct 11, 2023

WestLangley commented Oct 11, 2023

Mugen87 commented Oct 11, 2023 •

edited

WestLangley commented Oct 11, 2023

LeviPesin Oct 12, 2023

LeviPesin Oct 12, 2023

WestLangley Oct 12, 2023

WestLangley Oct 13, 2023

sunag Oct 13, 2023

WestLangley Oct 13, 2023

sunag Oct 13, 2023 •

edited

WestLangley Oct 14, 2023

aardgoose Oct 14, 2023

WestLangley Oct 15, 2023

Mugen87 commented Oct 14, 2023 •

edited

WestLangley commented Oct 14, 2023

mrdoob commented Oct 26, 2023

WebGPU: Introduce Fat Points #26930

WebGPU: Introduce Fat Points #26930

Conversation

WestLangley commented Oct 9, 2023 • edited

Mugen87 commented Oct 10, 2023

Mugen87 commented Oct 10, 2023 • edited

WestLangley commented Oct 10, 2023 • edited

Mugen87 commented Oct 10, 2023

Mugen87 commented Oct 11, 2023

WestLangley commented Oct 11, 2023

Mugen87 commented Oct 11, 2023 • edited

WestLangley commented Oct 11, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sunag Oct 13, 2023 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Mugen87 commented Oct 14, 2023 • edited

WestLangley commented Oct 14, 2023

mrdoob commented Oct 26, 2023

WestLangley commented Oct 9, 2023 •

edited

Mugen87 commented Oct 10, 2023 •

edited

WestLangley commented Oct 10, 2023 •

edited

Mugen87 commented Oct 11, 2023 •

edited

sunag Oct 13, 2023 •

edited

Mugen87 commented Oct 14, 2023 •

edited