Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GLTFLoader: Fix use of setPath with external resources #27106

Merged
merged 6 commits into from
Nov 4, 2023
Merged

GLTFLoader: Fix use of setPath with external resources #27106

merged 6 commits into from
Nov 4, 2023

Commits on Oct 16, 2023

  1. Fix for dispose error 

    sampleRenderTarget is being deleted and set to null by super.dispose();
the check for undefined was incorrect causing an attempt to call dispose on a null object.
    @Archimagus
    Archimagus committed Oct 16, 2023
    Configuration menu
    Copy the full SHA
    1a0b652 View commit details
    Browse the repository at this point in the history

  2. Removed disposal of sampleRenderTarget entierly

    @Archimagus
    Archimagus committed Oct 16, 2023
    Configuration menu
    Copy the full SHA
    6e4b77e View commit details
    Browse the repository at this point in the history

Commits on Nov 2, 2023

  1. Fix for setting path not affecting GLTF Sub Assets correctly.

    @Archimagus
    Archimagus committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    0057dfc View commit details
    Browse the repository at this point in the history

  2. Merge branch 'mrdoob:dev' into dev

    @Archimagus
    Archimagus committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    26b2af2 View commit details
    Browse the repository at this point in the history

  3. Fixed Comment

    @Archimagus
    Archimagus committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    92252a0 View commit details
    Browse the repository at this point in the history

Commits on Nov 3, 2023

  1. Update GLTFLoader.js 

    Fix code style.
    @Mugen87
    Mugen87 committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    39f0059 View commit details
    Browse the repository at this point in the history