Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TextureHelper #27151

Merged
merged 1 commit into from Nov 9, 2023
Merged

Add TextureHelper #27151

merged 1 commit into from Nov 9, 2023

Conversation

donmccurdy
Copy link
Collaborator

@donmccurdy donmccurdy commented Nov 8, 2023

Adds examples/jsm/helpers/TextureHelper.js, to allow easier debugging of compressed textures and data textures. Includes support for 2D, 3D, array, and cube textures.

Pulled from #26642.

Preview:

screenshot

@mrdoob mrdoob added this to the r159 milestone Nov 9, 2023
@mrdoob mrdoob merged commit ec09a96 into mrdoob:dev Nov 9, 2023
19 checks passed
@donmccurdy donmccurdy deleted the feat/texture-helper branch November 9, 2023 04:34
@mrdoob
Copy link
Owner

mrdoob commented Nov 30, 2023

Oh! Any chance we can also add the example in the screenshot?

@donmccurdy
Copy link
Collaborator Author

We'd need to merge #2664 to be able to show the array texture example -- it doesn't yet support everything I wanted (see: #26642 (comment)) but compressed array and cube textures are working. So if there's no regression in the PR, perhaps it's fine to clean that up and merge it without solving the remaining issues first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants