Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated code. #27467

Merged
merged 3 commits into from Jan 2, 2024
Merged

Remove deprecated code. #27467

merged 3 commits into from Jan 2, 2024

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Dec 29, 2023

Related issue: -

Description

Some deprecated code can be removed with r161.

@Mugen87 Mugen87 added this to the r161 milestone Dec 29, 2023
Copy link

github-actions bot commented Dec 29, 2023

📦 Bundle size

Full ESM build, minified and gzipped.

Filesize dev Filesize PR Diff
671.1 kB (166.8 kB) 670.5 kB (166.7 kB) -535 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Filesize dev Filesize PR Diff
451.9 kB (109.8 kB) 451.5 kB (109.7 kB) -382 B

@Mugen87
Copy link
Collaborator Author

Mugen87 commented Dec 29, 2023

@agviegas The example webgl_loader_ifc breaks with this change since https://github.com/IFCjs/web-ifc-three still relies on the deprecated mergeBufferGeometries().

Uncaught SyntaxError: The requested module 'three/examples/jsm/utils/BufferGeometryUtils' does not provide an export named 'mergeBufferGeometries' (at IFCLoader.js:4:10)

Do you mind migrating to mergeGeometries() (it's just renaming) and publish a new version of https://github.com/IFCjs/web-ifc-three?

@agviegas
Copy link
Contributor

Hey @Mugen87 sure! I can do that tomorrow.
By the way, web-ifc-three is now deprecated. We are now scaling as a company (not just me anymore) and are working on this new repository, which is much more modular, much faster and will progress a lot this year. I think we have 3 options here (all of them are fine by me)

  • Stick with web-ifc-three, I update it and it works again.
  • Change to components.
  • Remove it from the examples.

Sorry for the inconvenience of these changes. This started as a personal project and now is becoming something much bigger. This wouldn't be possible without your huge work, so I hope that this success will also allow us to give something back to you guys.

PD: We have moved the docs here, in case you want to update the three.js page reference to our docs.

@Mugen87
Copy link
Collaborator Author

Mugen87 commented Dec 31, 2023

As a quick fix, updating and using web-ifc-three is probably best. At a later point and depending on how you (or someone else from the IFCjs/components/ space) have time, it would be better to switch to components for a more future-proof solution.

@agviegas
Copy link
Contributor

agviegas commented Jan 1, 2024

Got it @Mugen87! I'll do it tomorrow 🙏

@agviegas
Copy link
Contributor

agviegas commented Jan 2, 2024

I have just published a new version 0.0.126. I haven't updated the Worker, which is optional and would require a lot of work. Using the normal loader without worker should be fine. Let me know how it goes!

@Mugen87 Mugen87 merged commit 5883c6c into mrdoob:dev Jan 2, 2024
12 checks passed
@mrdoob
Copy link
Owner

mrdoob commented Jan 3, 2024

The demo requires login? 🤔

Screenshot_20240103-171704

@agviegas
Copy link
Contributor

agviegas commented Jan 3, 2024

@mrdoob all examples and docs should be open in github pages, like the previous libraries. For instance, here's the demo for IFC loading.

@mrdoob
Copy link
Owner

mrdoob commented Jan 3, 2024

I clicked this link:

Screenshot_20240103-231730

@agviegas
Copy link
Contributor

agviegas commented Jan 3, 2024

My bad, I just updated the link in the README!

AdaRoseCannon pushed a commit to AdaRoseCannon/three.js that referenced this pull request Jan 15, 2024
* Remove deprecated code.

* Clean up.

* Examples: Bump version of `web-ifc-three`.
This was referenced Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants