Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WebGLRenderer: Fix env map Euler rotation #27785

Merged
merged 1 commit into from
Feb 21, 2024
Merged

WebGLRenderer: Fix env map Euler rotation #27785

merged 1 commit into from
Feb 21, 2024

Conversation

WestLangley
Copy link
Collaborator

Correction to #27758.

@WestLangley WestLangley added this to the r162 milestone Feb 21, 2024
@github-actions GitHub Actions
Copy link

📦 Bundle size

Full ESM build, minified and gzipped.

Filesize dev Filesize PR Diff
678 kB (168.6 kB) 678 kB (168.6 kB) +18 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Filesize dev Filesize PR Diff
458.4 kB (111.3 kB) 458.5 kB (111.3 kB) +18 B

@WestLangley
Copy link
Collaborator Author

@Mugen87 I have covered every use case, I think. Please see if this is working correctly for you.

A new build is required.

@Mugen87 Mugen87 merged commit 18a5375 into mrdoob:dev Feb 21, 2024
12 checks passed
@Mugen87 Mugen87 mentioned this pull request Feb 21, 2024
Merged
@WestLangley WestLangley deleted the dev-rotate_env_map branch February 21, 2024 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mugen87 Mugen87 Mugen87 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r162
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@WestLangley @Mugen87