HTMLMesh: do not render the script tag #27953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the script tag as well to the elements we skip
Elettrotecnica
pushed a commit
to Elettrotecnica/aframe-htmlmesh
that referenced
this pull request
Mar 20, 2024
Elettrotecnica
added a commit
to Elettrotecnica/aframe-vr
that referenced
this pull request
Mar 20, 2024
Clean up.
Mugen87
approved these changes
Mar 21, 2024
Elettrotecnica
pushed a commit
to Elettrotecnica/aframe-htmlmesh
that referenced
this pull request
Mar 21, 2024
vincentfretin
pushed a commit
to AdaRoseCannon/aframe-htmlmesh
that referenced
this pull request
Mar 21, 2024
See mrdoob/three.js#27953 Co-authored-by: Antonio Pisano <apisano@wu.ac.at>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Dear maintainers,
in the following proposed change I add the "script" tag to those that are not rendered on the HTML mesh.
In my use case, I have some dynamic HTML which may end up containing some javascript code. So far, this code would be rendered as text together with the mesh, which is not the expected behavior IMO.
I have also taken the chance to cleanup some duplication and move all of the "skipping" logics in the function to the very beginning.
Thanks for any feedback on this
All the best
Antonio