BatchedMesh: Fix exception when using Geometry with InterleavedBuffers #27978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ttribute, omit usage as sugested mrdoob#27973 (comment)
📦 Bundle sizeFull ESM build, minified and gzipped.
🌳 Bundle size after tree-shakingMinimal build including a renderer, camera, empty scene, and dependencies.
|
|
I haven't tested it but this looks good to me. |
gkjohnson
approved these changes
Mar 23, 2024
Mugen87
reviewed
Mar 23, 2024
marwie
added a commit
to needle-tools/three.js
that referenced
this pull request
Mar 24, 2024
…ttribute, omit usage (mrdoob#27978) as sugested mrdoob#27973 (comment)
marwie
added a commit
to needle-tools/three.js
that referenced
this pull request
Mar 24, 2024
…ttribute, omit usage (mrdoob#27978) as sugested mrdoob#27973 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #27973
Description
Adding geometry that has interleaved buffers currently throws because
setUsageis not defined on the InterleavedBufferAttribute.The PR enforces dstAttribute to
new BufferAttributeand removes the call tosetUsageas suggested by @gkjohnsonThis contribution is funded by 🌵 Needle