Add EventDispatcher to RaytracingRenderer #6136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added EventDispatcher prototype and added renderfinish event
| if ( blockY >= canvasHeight ) return; | ||
| if ( blockY >= canvasHeight ) { | ||
|
|
||
| dispatch( { type: "renderfinish" } ); |
There was a problem hiding this comment.
I think I would call the event complete instead.
|
Nice idea! |
|
I agree renderfinish was a bit awkward of an event name. Made the change! |
| if ( blockY >= canvasHeight ) return; | ||
| if ( blockY >= canvasHeight ) { | ||
|
|
||
| dispatch( { type: "complete" } ); |
There was a problem hiding this comment.
Yet another tweak... Why not just doing scope.dispatchEvent( { type: "complete" } )?
|
Another great tweak. Just made the change. |
|
Many thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think it would be a good idea to have an event dispatched after the render is finished with the RaytracingRenderer. There is no real way of telling right now and since it acts a bit differently then the other renderers I think it would beneficial.
I use it in my THREE.WebMExporter example here
http://chuckfairy.com/THREE.WebMExporter/examples/raytracing.html
Thanks for all the hard work guys!