Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor: GLSL error feedback & minification #6818

Merged
merged 16 commits into from
Jul 10, 2015
Merged

Conversation

tschw
Copy link
Contributor

@tschw tschw commented Jul 9, 2015

Depends on #6801, adds the last three commits.

@tschw tschw changed the title Editor: GLSL syntax checking & minification Editor: GLSL error feedback & minification Jul 9, 2015
@tschw
Copy link
Contributor Author

tschw commented Jul 9, 2015

Re-pushed: Simplification, a fixed typo and some forgotten whitespace.

mrdoob added a commit that referenced this pull request Jul 10, 2015
Editor: GLSL error feedback & minification
@mrdoob mrdoob merged commit 6d66a83 into mrdoob:dev Jul 10, 2015
@mrdoob
Copy link
Owner

mrdoob commented Jul 10, 2015

Thanks thanks!

@benaadams
Copy link
Contributor

btw @zz85 has done a interesting and very useful Emscripten pure js port of glsl-optimizer not what we necessarily want for easy to understand/learning glsl but something to bear in mind

@tschw
Copy link
Contributor Author

tschw commented Jul 11, 2015

Nice - and it's fast! We should integrate it as a stage before the minifier, which will then declutter the output. Ultimately, both would run when "Publish" is clicked, but we'd need a settings panel to make it all optional.

@tschw tschw deleted the EditorGlsl branch July 12, 2015 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants