Use setNeedsUpdate() instead of needsUpdate setter #6908
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For
Texture
,BufferAttribute
, andInterleavedBuffer
, introduce new methodsetNeedsUpdate()
instead of the faked propertyneedsUpdate
. Replace uses ofneedsUpdate = true
and document the new APi.Naming:
setNeedsUpdate()
could be named something likeincrementVersion()
if you prefer. I don't thinkupdate()
is appropriate as it doesn't directly perform an update.Material
and uniforms don't have a version counter, They still use the boolean flagneedsUpdate
(no change).