Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use setNeedsUpdate() instead of needsUpdate setter #6908

Closed
wants to merge 1 commit into from

Conversation

dubejf
Copy link
Contributor

@dubejf dubejf commented Jul 25, 2015

For Texture, BufferAttribute, and InterleavedBuffer, introduce new method setNeedsUpdate() instead of the faked property needsUpdate. Replace uses of needsUpdate = true and document the new APi.

Naming: setNeedsUpdate() could be named something like incrementVersion() if you prefer. I don't think update() is appropriate as it doesn't directly perform an update.

Material and uniforms don't have a version counter, They still use the boolean flag needsUpdate (no change).

@mrdoob
Copy link
Owner

mrdoob commented Jul 26, 2015

Hmmm... I'll think I'll hold this one for the next cycle.

@threejsworker
Copy link

The examples of this pullrequest are now built and visible in threejsworker. To view them, go to the following link:

http://threejsworker.com/viewpullrequest.html#6908

@mrdoob mrdoob closed this Oct 15, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants