Make readRenderTargetPixels() compatible with float extensions #7278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
support WEBGL_color_buffer_float and EXT_color_buffer_half_float also fixed a cleanup bug were the function would exit leaving the wrong buffer bound
|
@kintel looks good? |
|
I don't see anything wrong with it, but I also don't have any personal experience with pixel readback in WebGL. A demo is worth a thousand lines of code : ) |
|
Yeah, that's a good point. |
|
I'll do it, but it will be a demo that only works on Chrome and Firefox (at present times), with each exercising a different code path. I have zero fallback for Safari and mobile. |
|
@nraynaud Chrome supports color_buffer_float? since when? |
|
@kintel no, but it can read floats through "IMPLEMENTATION_COLOR_READ_TYPE", I sent you a pull request a few days ago. |
mrdoob
added a commit
that referenced
this pull request
Oct 4, 2015
Make readRenderTargetPixels() compatible with float extensions
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
support WEBGL_color_buffer_float and EXT_color_buffer_half_float
also fixed a cleanup bug were the function would exit leaving the wrong buffer bound