Additional RingGeometry Fix #7353
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ngGeometry Removes redundant vertices from RingGeometry when the ring is complete and welds the seem Reduces the minimum number of concentric rings in RingGeometry to one Removes some redundant calculation form Ring Geometry
…not visible" This reverts commit eee16ef.
|
The implementation of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change removes the extra triangles connecting the ends of a partial RingGeometry, and sets the minimum number of concentric bands to one, like merpnderp's #4878 does. However, it also:
Targeting Dev as requested in #4899 (comment)