Unittests #7708
Merged
Unittests #7708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 12 commits
November 29, 2015 10:57
…artcomparer since there are some properties which are missing. Since this is a normal behavior these properties need to be excluded manually
…ned properties like bones. If you compare the originial with the json object, these properies will be missed. For that reson you cant use smartcompare and need to exclude props manually§
mrdoob
added a commit
that referenced
this pull request
Dec 1, 2015
|
Many thanks! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
Since I remove lodash some tests are working again but containing wrong checks and other issues. I hope I fixed them. The tests for EdgesGeometry are still broken because I didn't really get what singularity and needle are trying to do, but this is the next task :)