Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow zooming while rotating (OrbitControls) #8634

Merged
merged 1 commit into from
Apr 16, 2016

Conversation

BroHammie
Copy link
Contributor

Significantly older version of OrbitControls allowed for zooming while rotating. Hoping we can add this back in.

@WestLangley
Copy link
Collaborator

How do you manage to zoom and rotate the camera at the same time?

@BroHammie
Copy link
Contributor Author

Hold down the the left mouse button and then operate the mouse wheel(while left button is still down).
webgl_buffergeometry_drawcalls.html is a good example to test the changes.

@WestLangley
Copy link
Collaborator

Hmmm... One can't do that on a Mac.

Also, wouldn't that lead to different behavior between a touch device and a mouse?

@BroHammie
Copy link
Contributor Author

This would have no impact on the touch devices as touch devices call into the onTouchStart function. And only have 1/2/3 finger functions, I am assuming similar to a Mac device.

@WestLangley
Copy link
Collaborator

Right. That results in different behaviors: you could scroll and zoom simultaneously with a PC, but not a touch device, and not a Mac.

Just stating the implications of this PR so it is clear -- not passing judgement.

@MasterJames
Copy link
Contributor

I with limited weight here would say don't let the weak links limit those with more ability and so I would say disabling functionality because other people can't handle or achieve it is not the right way forward. "Let them catch up if they can."
What about zoomimg in VR/AR? Certainly there's ways to do both with various tools. With that said and with open source in mind, Orbit Controls etc. is not the only way one can make variations as needed so it really doesn't matter to coders with open source.

@mrdoob mrdoob merged commit a58012b into mrdoob:dev Apr 16, 2016
@mrdoob
Copy link
Owner

mrdoob commented Apr 16, 2016

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants