Blender Exporter Normals Fix #8647
Conversation
…were flipped on their sides 90 degrees. This fixes that issue so lighting works as expected.
|
Wonderful! A relevant ticket: #8592 |
|
@phfatmonkey it also appears that bone rotation is exported incorrectly too (rotated along wrong axis). Is that something you're familiar with? |
|
Hi, @delvarworld. The bones were being flipped before my last PR #8412. Are they still being flipped incorrectly? |
|
@phfatmonkey bones are clobbered with the exporter on dev #6050 (comment) |
Ha! Guessed right there #8592 (comment) . One issue less on the Blender list. Awesome! |
|
@delvarworld Are you using the latest exporter from the dev branch? @tschw What do you mean by split the two lines? Do you mean split into an if statement and not a conditional assignment? So: ? |
|
Oh wait... It's actually one statement. Let's just get it merged than :). |
|
😊 |
|
I'm seeing the normals issue again with Three.js r79 blender exporter with Blender 2.77. Reverting commit bb0ff5d solved the problem for me. |
Revert "Normals weren't properly transformed in last exporter change so they were flipped on their sides 90 degrees. This fixes that issue so lighting works as expected. (mrdoob#8647)" This reverts commit bb0ff5d. Revert "Revert "Normals weren't properly transformed in last exporter change so they were flipped on their sides 90 degrees. This fixes that issue so lighting works as expected. (mrdoob#8647)"" This reverts commit fec1ebb948eac7de1de95efe003e3347b1b3a1a0.
…so they were flipped on their sides 90 degrees. This fixes that issue so lighting works as expected. (mrdoob#8647)" This reverts commit bb0ff5d.
Normals weren't properly transformed with last exporter change so they were flipped on their side 90 degrees. This fixes that so lighting works as expected now.