Remove mouseout handlers from OrbitControls #8832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Uh! Somehow I missed this one... |
|
Thanks! |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(re: #8157 )
The mouseout handler in OrbitControls was added here: #7434
The change makes no sense because it disables the built-in mouse capturing behavior in OrbitControls, creating a lot of dead code. After removing the mouseout handlers, I can't reproduce any sticky mouse behavior in OS X Chrome, Safari or Firefox:
http://acko.net/files/dump/orbitcontrols/error.html
http://acko.net/files/dump/orbitcontrols/fixed.html
This is particularly bad when you have elements overlapping the renderer, because they also trigger mouseout, e.g. http://acko.net/files/dump/orbitcontrols/overlay.html
So either the original request was due to another browser/OS failing to fire the mouseup event, or a specific situation where mouseup is not firing (iframes?). Either way, the current behavior is not usable nor consistent and this change should be reverted.