DRYer texture creation for different map types #9336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Noticed there was a fair bit of repetition in each map line case. This pulls the case logic out into a reusable function This also adds support for texture parameters for specular maps as a result. (Expands on mrdoob#9311 and mrdoob#9308)
| @@ -358,6 +359,22 @@ THREE.MTLLoader.MaterialCreator.prototype = { | |||
|
|
|||
| return baseUrl + url; | |||
| }; | |||
|
|
|||
| var setMapForType = function ( mapType, value ) { | |||
There was a problem hiding this comment.
function setMapForType( mapType, value ) {There was a problem hiding this comment.
@mrdoob changed. I thought there was a preference for this style of declaring a function (looking at the resolveURL function right above it)
|
Thanks! |
aardgoose
pushed a commit
to aardgoose/three.js
that referenced
this pull request
Oct 7, 2016
* DRYer texture creation for different map types Noticed there was a fair bit of repetition in each map line case. This pulls the case logic out into a reusable function This also adds support for texture parameters for specular maps as a result. (Expands on mrdoob#9311 and mrdoob#9308) * Change style of function declaration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed there was a fair bit of repetition in each map line case. This pulls the case logic out into a reusable function
This also adds support for texture parameters for specular maps as a result. (Expands on #9311 and #9308)