Additional Maya Exporter Updates / Fixes #9485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the previous commit there were still situations where export selected would not work properly. - Fixing Export Selected: Removed most of the calls to ls() which does a physical select which would really mess up the attempts to Export Selected. In place I am using listHistory followed by listConnections which seems to work correctly. - Updated references to "Diffuse" in maya to be "Color" which is what was actually being used. Added comments about this to the README. - Changed code reference of "diffuse" to "color" where it was appropriate for clarity. - Added code that keeps it from exporting bones/animations on Export Selected because it currently doesn't work. Also added Note in the export dialog to this effect. - Fixed how opacity was exported. Previously was grabbing the A channel of the RGB object, but Maya stores transparency in all three RGB channels. Grabbing R channel for opacity value in JSON. - Added comment regarding the JSON exporter hack at the bottom of the file for clarity. - Turned on Pretty Output by default. I saw no reason not to now that I've cleaned up the output. - Removed depreciated arguments from the frameLayout call in MEL. -bs is no longer supported. - Moved the bones checkbox and related textfield into the animation section. Seemed logical.
|
Thanks! |
aardgoose
pushed a commit
to aardgoose/three.js
that referenced
this pull request
Oct 7, 2016
In the previous commit there were still situations where export selected would not work properly. - Fixing Export Selected: Removed most of the calls to ls() which does a physical select which would really mess up the attempts to Export Selected. In place I am using listHistory followed by listConnections which seems to work correctly. - Updated references to "Diffuse" in maya to be "Color" which is what was actually being used. Added comments about this to the README. - Changed code reference of "diffuse" to "color" where it was appropriate for clarity. - Added code that keeps it from exporting bones/animations on Export Selected because it currently doesn't work. Also added Note in the export dialog to this effect. - Fixed how opacity was exported. Previously was grabbing the A channel of the RGB object, but Maya stores transparency in all three RGB channels. Grabbing R channel for opacity value in JSON. - Added comment regarding the JSON exporter hack at the bottom of the file for clarity. - Turned on Pretty Output by default. I saw no reason not to now that I've cleaned up the output. - Removed depreciated arguments from the frameLayout call in MEL. -bs is no longer supported. - Moved the bones checkbox and related textfield into the animation section. Seemed logical.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the previous commit there were still situations where export
selected would not work properly. In exploring why this was happening I realized that the ls() command employed in the plugin fundamentally does not support export selected. I did some research and found a way to replace MOST of these calls. The way that animations are being exported appears to require the use of the ls() command and thus cannot be supported in Export Selected. I’ve added code that restricts the animation parts to Export All and added comments in the plugin dialog and the README to explain this. I will continue to research it in hopes of finding a fix for this in the future.
The other large fix is for opacity which would not work previously. It now seems to work correctly.