Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add required WebGL constants to glTFLoaderUtils.js #9721

Merged
merged 1 commit into from Sep 20, 2016

Conversation

richtr
Copy link
Contributor

@richtr richtr commented Sep 20, 2016

WebGLRenderingContext constant values are not exposed in Safari so hard-code the WebGL constants required for the glTF model loader in to THREE.glTFLoaderUtils.WEBGL_CONSTANTS.

Fixes #8973.

@richtr richtr changed the title Add used WebGL constants to glTFLoaderUtils.js Add required WebGL constants to glTFLoaderUtils.js Sep 20, 2016
@christimiller
Copy link

Did a quick test of several animated quads with a single material (texture and alpha), seems to work so far. Will test with some more model types later today.

@mrdoob mrdoob merged commit 20aedf9 into mrdoob:dev Sep 20, 2016
@mrdoob
Copy link
Owner

mrdoob commented Sep 20, 2016

Thanks!

@richtr richtr deleted the bugfix/glTF-constants branch September 20, 2016 20:24
richtr added a commit to richtr/three.js that referenced this pull request Sep 20, 2016
aardgoose pushed a commit to aardgoose/three.js that referenced this pull request Oct 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants