Pre-slice potentially large ArrayBuffers to avoid RangeErrors from GLTFLoader #9828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FWIW, this issue only affects three.js < r81 (i.e. prior to this change introduced in the r81 release). |
|
Maybe we should add a |
|
This change does not affect newer versions. It just means the loader works with older versions and newer versions. Maybe we don't need the revision check? |
|
Well... The proposed code is not as readable as the current one. That's code that we'll have to maintain in the future, so by adding the revision check the next person that reads the code will understand why it's like that. |
|
Closing, as this seems to be obsolete. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bug fix prevents passing a potentially very large
ArrayBufferin to Float32Array.prototype.set.By pre-slicing the
ArrayBufferobject to the required values it prevents the browser from throwing aRangeError: Source is too largeerror in the case that the original un-sliced inputArrayBufferobject is too large (when we are are only really interested in a small subset of it).