Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call renderer.clear() from StereoEffect if renderer.autoClear is true #9877

Merged
merged 1 commit into from
Oct 18, 2016

Conversation

takahirox
Copy link
Collaborator

@takahirox takahirox commented Oct 18, 2016

This PR enables users to control autoClear for StereoEffect
by letting StereoEffect call renderer.clear() only if renderer.autoClear is true like VREffect does.

I needed this when I attempted to try Outline drawing with StereoEffect.

My outline drawing requires two rendering pass with StereoEffect
and second pass needs autoClear off but I couldn't control it from outside.

setupForNormalRendering();
renderer.autoClear = true;
effect.renderer( scene, camera );

setupForOutlineDrawing();
renderer.autoClear = false;
effect.renderer( scene, camera );

@mrdoob mrdoob merged commit 73edfb8 into mrdoob:dev Oct 18, 2016
@mrdoob
Copy link
Owner

mrdoob commented Oct 18, 2016

Thanks!

@takahirox takahirox deleted the StereoEffectAutoClear branch October 18, 2016 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants