-
-
Notifications
You must be signed in to change notification settings - Fork 40
[bump_pyo3_version] Update to pyo3 0.8.0 and maturin #59
Conversation
Great! Thanks @packysauce. |
Only failing on 3.5, 3.6 is good. I'm not sure how to specify "on python3.5, use version X. on python3.6 use version Y" since the version is set in the lockfile. I'll dig unless you know off the top of your head. thanks for the quick response! |
Yeah, was thinking about simply updating |
Looks great now. Thank you very much! Merging. |
so, reading over the benchmark results from travis.... am i correct in interpreting them as "wow pretty slow"? those numbers seem pretty outlandish |
Something is off. These values don't seem right to me. I wonder if we look at a development build or a regression here. 🤔 |
debug mode confirmed, manually running benchs with a release build point to "real fast" |
Like the title states. 0.6.0 introduced some API incompatibilities that I have fixed to the best of my abilities. I also went ahead and updated every dep involved, and fixed all incompatibilities discovered.
I ran profiles, tests, and played around with it in the python shell, and from what I can tell works well again
should fix #57