Skip to content
This repository has been archived by the owner on Sep 14, 2023. It is now read-only.

[bump_pyo3_version] Update to pyo3 0.8.0 and maturin #59

Merged
merged 14 commits into from
Sep 19, 2019

Conversation

packysauce
Copy link
Contributor

@packysauce packysauce commented Sep 19, 2019

Like the title states. 0.6.0 introduced some API incompatibilities that I have fixed to the best of my abilities. I also went ahead and updated every dep involved, and fixed all incompatibilities discovered.

I ran profiles, tests, and played around with it in the python shell, and from what I can tell works well again

should fix #57

@mre
Copy link
Owner

mre commented Sep 19, 2019

Great! Thanks @packysauce.
There is an issue with Python 3 and matplotlib. It's unrelated to your change (which is perfect), but it affects the CI pipeline. I wonder if you could try to make it work? Maybe by updating the matplotlib dependency?

@packysauce
Copy link
Contributor Author

Only failing on 3.5, 3.6 is good. I'm not sure how to specify "on python3.5, use version X. on python3.6 use version Y" since the version is set in the lockfile. I'll dig unless you know off the top of your head.

thanks for the quick response!

@mre
Copy link
Owner

mre commented Sep 19, 2019

Yeah, was thinking about simply updating matplotlib to the latest version, but it looks like 3.1.1 already is. So maybe we can try downgrading it instead to the latest version that works for both?

@mre
Copy link
Owner

mre commented Sep 19, 2019

Looks great now. Thank you very much! Merging.

@mre mre merged commit bc73e21 into mre:master Sep 19, 2019
@packysauce
Copy link
Contributor Author

so, reading over the benchmark results from travis.... am i correct in interpreting them as "wow pretty slow"? those numbers seem pretty outlandish

@mre
Copy link
Owner

mre commented Sep 19, 2019

Something is off. These values don't seem right to me. I wonder if we look at a development build or a regression here. 🤔

@packysauce
Copy link
Contributor Author

debug mode confirmed, manually running benchs with a release build point to "real fast"
I'll work on a PR to make benchs run with release

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make install doesn't work.
2 participants