Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial Hanzi math implementation #46

Merged
merged 5 commits into from
Jul 14, 2024
Merged

Initial Hanzi math implementation #46

merged 5 commits into from
Jul 14, 2024

Conversation

mreichhoff
Copy link
Owner

Messy, buggy...it's a start though.

Messy, likely buggy...it's a start though.
Copy link

github-actions bot commented Jul 14, 2024

Visit the preview URL for this PR (updated for commit 3c58705):

https://hanzigraph--pr46-math-command-3yin3wz5.web.app

(expires Mon, 15 Jul 2024 13:21:12 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: dbfc59c053d815dc5dedbd48d2959ec4a33d1b39

@mreichhoff
Copy link
Owner Author

mreichhoff commented Jul 14, 2024

!math 亻+寸+厂+人+⺆ (result: )

!math 腐-仌 (result: )

!math 酒-氵+各 (result: )

!math 氨-女 (result: )

!math 力+口+壴 (result: )

!math 嘉-壴 (result: )

known bad results:

  • operations like: !math 加+加-加+加-加 (the empty list handling comment is relevant...that must be improved)
  • self-addition and subtraction: the components data doesn't duplicate components (e.g., 从-->人, it doesn't have two 人 children)
  • similar thing for addition of component and subcomponent: !math 力+口+壴+豆 also gets , since is under . Users may or may not want such transitiveness in that case.

@mreichhoff mreichhoff merged commit d5ceabb into main Jul 14, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant