Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problems with big endian #1

Closed
laufhannes opened this issue Jul 31, 2016 · 2 comments
Closed

Problems with big endian #1

laufhannes opened this issue Jul 31, 2016 · 2 comments

Comments

@laufhannes
Copy link

The perl module has some problems with big endian values.

  • The parser will fail for big endian files with array-valued fields (such as for hrv)
  • The parser will fail on big endian systems
    • see Runalyze/Runalyze#1875 for a related issue
    • message numbers will be wrong
    • for a fix:
      • $endian != $my_endian should be $endian (#L4780, #L4828, #L4868)
      • add $v = reverse $v if ref $desc->{endian_converter} eq 'ARRAY'; to #L4927

I can add a pull request for this, but I don't have a big endian system to check and a final confirmation that the last point fixes wrong ordering of arrayed-valued fields is still missing (see https://github.com/Runalyze/Runalyze/issues/1875#issuecomment-234050418).

PS: Thanks for having a repo for Kiyokazu's perl module!

mrihtar added a commit that referenced this issue Aug 30, 2016
@mrihtar
Copy link
Owner

mrihtar commented Aug 30, 2016

Kiyokazu created a patch (d951563), which should fix this problem.

@mrihtar
Copy link
Owner

mrihtar commented Oct 17, 2016

I am closing this, as there are no other complaints about this patch for now.

@mrihtar mrihtar closed this as completed Oct 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants