Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add CacheControl to all requests #294

Merged
merged 1 commit into from
Sep 3, 2020
Merged

add CacheControl to all requests #294

merged 1 commit into from
Sep 3, 2020

Conversation

Uzlopak
Copy link
Contributor

@Uzlopak Uzlopak commented Sep 2, 2020 •
edited
Loading

Always bypass Caching
making caching optional makes no sense

@Uzlopak
Copy link
Contributor Author

Uzlopak commented Sep 2, 2020

#291

@mrin9 mrin9 merged commit 448bd0c into rapi-doc:master Sep 3, 2020
@mrin9
Copy link
Collaborator

mrin9 commented Sep 3, 2020 •
edited
Loading

Thanks for the PR !!!
but dont think it fixes #291 that is about caching the OpenAPI spec itself.
The PR is for the API calls made using the TRY button

@Uzlopak Uzlopak deleted the feature/no-cache-on-all-calls branch September 3, 2020 09:41
@ahmadnassri
Copy link

agreed with @mrin9

@jdemaeyer
Copy link

Note that this change broke the "TRY" button for APIs that are served from a different origin unless these explicitly allow the Cache-Control header in their CORS preflight response. (Not a change request, just wanted to let you know :))

@jdemaeyer jdemaeyer mentioned this pull request Nov 10, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrin9 mrin9 mrin9 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Uzlopak @mrin9 @ahmadnassri @jdemaeyer