Switch to OwnedFd #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rust 1.63 improved the handling of file descriptors by including the new OwnedFd and BorrowedFd structures. This clarifies the semantics of the file descriptors we can return, and most importantly around who has to close the file descriptor. We also had that ambiguity, where depending on the structure implementing the FromRawFd trait the caller was using, we would require or not the caller to explicitly close the file descriptor we returned. This essentially meant that we would expect the caller responsible of closing the FD we allocated, which is what OwnedFd is about. Make it clear and unambiguous by switching to an OwnedFd. Signed-off-by: Maxime Ripard <maxime@cerno.tech>
Signed-off-by: Maxime Ripard <maxime@cerno.tech>
It seems to be confused by the DmaBufHeapType structure and requires to use Self as the enum name, even though it doesn't make much sense. Signed-off-by: Maxime Ripard <maxime@cerno.tech>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.