-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge commits are failing length check #110
Comments
Should we just ignore messages starting with |
I think that makes sense as these are outside the control of the user. Alternatively perhaps there is a way to detect if the commit was a merge commit? I'm not sure exactly the range of values that come from |
Update on this. There is no way to detect for sure that a commit is a merge commit from just the event. It is possible by making some API calls. For each commit in the push event we'd need to:
Footnotes |
A more generic approach would be to have a parameter to ignore commits whose title matches the given patterns. The default patterns for such a filter could be for matching GitHub's default merge commit title. |
@Fryuni I think the pattern matching approach is far simpler and would generalize across Git repositories. |
It took me a while to get back to this, but PR is open now. Also, @mristin, I think you can send the command for the dependabot's PRs to re-evaluate and close themselves since everything was updated on a single PR |
There was already logic to ignore merge commits, but it was using a very restricted regular expression. This PR: - Improve the existing merge commit detection. - Allow users to disable merge commit detection. - Allow users to provide custom patterns to ignore Related issues: - Closes #110 Signed-off-by: Luiz Ferraz <luiz@lferraz.com>
When a pull request is merged it will contain a subject message similar to the following:
This is longer than the default 50 character limit. When the action runs on the main branch it fails.
The text was updated successfully, but these errors were encountered: