cpu.architecture: remove un-needed temp register in %bit-test

mrjbq7 · Aug 22, 2023 · 18b341d · 18b341d
1 parent e851bf5
commit 18b341d
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 6 deletions.
diff --git a/basis/compiler/cfg/instructions/instructions.factor b/basis/compiler/cfg/instructions/instructions.factor
@@ -226,8 +226,7 @@ use: src/int-rep ;
 
 FOLDABLE-INSN: ##bit-test
 def: dst/tagged-rep
-use: src1/int-rep src2/int-rep
-temp: temp/int-rep ;
+use: src1/int-rep src2/int-rep ;
 
 ! Float arithmetic
 FOLDABLE-INSN: ##add-float

diff --git a/basis/cpu/architecture/architecture.factor b/basis/cpu/architecture/architecture.factor
@@ -270,7 +270,7 @@ HOOK: %not     cpu ( dst src -- )
 HOOK: %neg     cpu ( dst src -- )
 HOOK: %log2    cpu ( dst src -- )
 HOOK: %bit-count cpu ( dst src -- )
-HOOK: %bit-test cpu ( dst src1 src2 temp -- )
+HOOK: %bit-test cpu ( dst src1 src2 -- )
 
 HOOK: %copy cpu ( dst src rep -- )
 

diff --git a/basis/cpu/arm/64/64.factor b/basis/cpu/arm/64/64.factor
@@ -90,7 +90,7 @@ M: arm.64 %bit-count
     D0 swap DX FMOVgen ;
 
 M: arm.64 %bit-test
-    [ 2^ swap TSTi ] dip
+    [ 2^ swap TSTi ] keep
     swap dup EQ CSEL ;
 
 M: arm.64 %and rot ANDr ;

diff --git a/basis/cpu/x86/x86.factor b/basis/cpu/x86/x86.factor
@@ -771,9 +771,9 @@ M: x86 immediate-bitwise?
         { cc/<>= [ src1 src2 compare call( a b -- ) label JP ] }
     } case ;
 
-M:: x86 %bit-test ( dst src1 src2 temp -- )
+M:: x86 %bit-test ( dst src1 src2 -- )
     src1 src2 BT
-    dst temp \ CMOVB (%boolean) ;
+    dst src2 \ CMOVB (%boolean) ;
 
 M: x86 enable-cpu-features
     enable-min/max