Settings: Fixed loading and defaults.

[madmaxoft]

The "use default location" was not applied when starting Minutor. This change produces more understandable flow of the settings initialization.

Fixes #93, at least on Windows.

[EtlamGit]

Hi @madmaxoft , as it seems that there are some ambiguities what location to choose in the settings dialog, I see these options for us to improve:

• write an extra comment to use the Minecraft base folder not the saves folder
• automatically detect a wrong chosen saves folder and remove it
• work with both variants, as the saves folder may be named differently anyway

While thinking more about it, I prefer the last option. What do you think?

[madmaxoft]

I'm always for making things easier for the end user, so working with both would be my choice. However, it is outside of the scope of this PR, I think.

[madmaxoft]

@EtlamGit How about this behavior:

• The Settings object always contains the base folder
• When the user browses for the "Minecraft Location", the code in the Browse button handler inspects the folder they choose. If it is named "saves" and has no "saves" subfolder in it, the code uses the parent folder silently.

This should work for all the cases and prevent any confusion. The only case it wouldn't work would be if the user had a world named "saves" and they chose the saves folder instead of the base folder. But I think it's better to leave it like that.

[EtlamGit]

(The only save method would be to search for a folder that contains subfolders which themselves contain a file called level.dat that parses to valid NBT data.)

I like your approach...

[mrkite]

My only concern is you don't want the program walking all over the place, recursively checking directories for level.dat. Especially if they point to something really slow like a network drive. So we definitely want to keep the automatic checking to a minimum.

[tigerw]

@madmaxoft xoft, is this by any chance, a Cuberite-style comment, in minutor?

[tigerw]

What is this, some sort of crossover episode?