Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add to melpa? #3

Closed
jbr opened this issue Mar 27, 2023 · 21 comments · Fixed by melpa/melpa#8577
Closed

Add to melpa? #3

jbr opened this issue Mar 27, 2023 · 21 comments · Fixed by melpa/melpa#8577

Comments

@jbr
Copy link

jbr commented Mar 27, 2023

I just came here from awesome-nu#editor-extensions and was excited to see that there's a nu major mode for emacs now! I am setting up straight-use-package for the first time in order to use this, but imagine there are probably people who would prefer to install from melpa. I've added a package to melpa before and it was fairly straightforward. Would it make sense to publish this package to melpa?

Thanks!

@azzamsa
Copy link
Collaborator

azzamsa commented Mar 29, 2023

Hi.

I switched back to ZSH after many issues I faced in NuShell. Mainly nushell/nushell#6339.
Currently, I don't plan to switch back to NuShell again. It is okay for you to take ownership of this package.

@mrkkrp
Copy link
Owner

mrkkrp commented May 17, 2023

Hey @azzamsa, I'd like to take over and maintain this package. I've been maintaining some Emacs Lisp code for years: https://github.com/mrkkrp?tab=repositories&q=&type=&language=emacs+lisp&sort=stargazers. If you agree, how should we proceed about it?

@azzamsa
Copy link
Collaborator

azzamsa commented May 18, 2023

If you agree, how should we proceed about it?

100 %. I will provide any action necessary.

@mrkkrp
Copy link
Owner

mrkkrp commented May 19, 2023

🎉 I guess the next logical step is to transfer the repo to my account.

@azzamsa
Copy link
Collaborator

azzamsa commented May 20, 2023

@mrkkrp done.

@mrkkrp
Copy link
Owner

mrkkrp commented May 22, 2023

@azzamsa, Hmm, strange, I haven't received any notification about this. Are you sure you used the right handle? I know people often make mistakes in mine. Could you perhaps check?

@azzamsa
Copy link
Collaborator

azzamsa commented May 22, 2023

I have re-transfer the ownership to your handle.

@mrkkrp
Copy link
Owner

mrkkrp commented May 22, 2023

Strange, I still haven't received anything 🤷‍♂️

@azzamsa
Copy link
Collaborator

azzamsa commented May 23, 2023

I have tried both mrkkrp and @mrkkrp. However, it doesn't have pop-up selection as if we add more contributor to the repo.

image

@mrkkrp
Copy link
Owner

mrkkrp commented May 23, 2023

Yeah, pretty weird. Maybe it is something we could report to GitHub (I will try to do that in the coming days). Looks like a bug to me.

@mrkkrp
Copy link
Owner

mrkkrp commented May 31, 2023

@azzamsa I contacted GitHub about this and they suggested enabling notification both via the web-interface and via email. I did that. Can you please try again?

@azzamsa
Copy link
Collaborator

azzamsa commented May 31, 2023

Should I use @ or not?
Context #3 (comment)

@mrkkrp
Copy link
Owner

mrkkrp commented Jun 1, 2023

I think it should work without it.

@azzamsa
Copy link
Collaborator

azzamsa commented Jun 1, 2023

image

@mrkkrp
Copy link
Owner

mrkkrp commented Jun 2, 2023

I've got another reply from GitHub. They looked a bit more into it and I think they fixed the problem. Can you try one last time? Really sorry for this long sequence of attempts!

@azzamsa
Copy link
Collaborator

azzamsa commented Jun 2, 2023

image

@mrkkrp
Copy link
Owner

mrkkrp commented Jun 2, 2023

It worked! Thanks for not giving up :-)

@azzamsa
Copy link
Collaborator

azzamsa commented Jun 2, 2023

@mrkkrp would you like to share what's happening? is it a GitHub bug?

@mrkkrp
Copy link
Owner

mrkkrp commented Jun 3, 2023

It turned out that if you opt out of email notifications then the request won't be sent to your email and it won't show up in the web interface either. So, I had to enable email notifications, but even then it at first defaulted to an email address I haven't used in 8 years instead of my primary email. I consider the fact that opting out of email notifications prevents any kind of notifications about repository transfers a bug.

@azzamsa
Copy link
Collaborator

azzamsa commented Jun 4, 2023

Same here. I never use any email notifications for the app I open every day, including Github.
If someone would like to transfer a repository to me, I need to activate my email notification first.

mrkkrp added a commit to mrkkrp/awesome-nu that referenced this issue Jun 4, 2023
Nushell mode has a new maintainer now and thus a new home.

mrkkrp/nushell-mode#3 (comment)
@mrkkrp
Copy link
Owner

mrkkrp commented Jun 12, 2023

The package is now on MELPA.

@mrkkrp mrkkrp closed this as completed Jun 12, 2023
beljakkw added a commit to beljakkw/awesome-nu that referenced this issue Aug 10, 2024
Nushell mode has a new maintainer now and thus a new home.

mrkkrp/nushell-mode#3 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants