Redefine .new to Raise an Error
#26
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Invoking `MXNet::NDArray.new` constructs an invalid instance. Specifically, `ndarray_allocate()` is called but a handle is never allocated, so future calls to `mxnet_ndarray_get_handle()` return `NULL` which breaks code that doesn't deal with this case. There isn't any obvious use case for `MXNet::NDArray.new` and the Python API doesn't have an equivalent, so simply redefine it to raise an error.
|
Thank you for reporting the issue and proposing changes for fixing it. I resolved it by the different way. |
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Invoking
MXNet::NDArray.newconstructs an invalid instance. Specifically,ndarray_allocate()is called but a handle is never allocated, so future calls tomxnet_ndarray_get_handle()returnNULLwhich breaks code that doesn't deal with this case (specifically in my case the Ruby executable crashes when I try to do anything with this instance).There isn't any obvious use case for
MXNet::NDArray.newand the Python API doesn't have an equivalent, so simply redefine it to raise an error.