Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nginx plus integration test #41

Merged
merged 2 commits into from
Feb 29, 2016
Merged

Nginx plus integration test #41

merged 2 commits into from
Feb 29, 2016

Conversation

mrkschan
Copy link
Owner

No description provided.

mrkschan pushed a commit that referenced this pull request Feb 29, 2016
@mrkschan mrkschan merged commit 9923789 into master Feb 29, 2016
@ruflin
Copy link

ruflin commented Feb 29, 2016

@mrkschan Wasn't aware that cover is part of the standard repo. Good to know, means we can also remove it on our side.

@mrkschan
Copy link
Owner Author

mrkschan commented Mar 1, 2016

close #35

@mrkschan
Copy link
Owner Author

mrkschan commented Mar 1, 2016

@ruflin Actually, I find that the docker container cannot go get it and then took a look at the docs of cover, where I find it's no longer maintained according to the docs.

FYI, find below the error message from the docker container.

mkdir -p build/coverage
# coverage tools
go get golang.org/x/tools/cmd/cover
package golang.org/x/tools/cmd/cover: unrecognized import path "golang.org/x/tools/cmd/cover"
scripts/Makefile:70: recipe for target 'prepare-tests' failed
make: *** [prepare-tests] Error 1

ruflin added a commit to ruflin/beats that referenced this pull request Mar 1, 2016
golang.org/x/tools/cmd/cover loading is not needed anymore as it is part of Golang 1.5

See mrkschan/nginxbeat#41
@ruflin
Copy link

ruflin commented Mar 1, 2016

Removing it in all our beats: elastic/beats#1072

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants