add PingListener #517
Merged
add PingListener #517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrniko
requested changes
Feb 8, 2018
| @@ -246,6 +242,11 @@ public void addConnectListener(ConnectListener listener) { | |||
| mainNamespace.addConnectListener(listener); | |||
| } | |||
|
|
|||
| @Override | |||
| public void addPingListeners(PingListener pingListener) { | |||
There was a problem hiding this comment.
@lovebing Please rename method to addPingListener since you're adding only one listener at a time
|
@mrniko OK, it done. |
mrniko
approved these changes
Feb 9, 2018
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PingListener for handling ping event. Sometimes it is important to know when clients send ping data to server. In distributed environments, to manage the information of online clients, we can put it into Redis when servers receive the ping data from clients, and set or update a expiry time for each client. In this way, managing the data of online clients becomes easy.