Make tests compatible with BusterJS 0.7.4+ #40
Conversation
As of BusterJS 0.7.4 assert, refute and expect are no longer global which breaks the test suite. Using buster.assert, buster.refute and buster.expect solves the issue.
|
@kamilgrymuza thank you for your pull request. Could you remove the second commit (kamilgrymuza@ff0a84b), as that is also in another pull request? |
|
You're welcome (thanks to you for your effort) and sure - I've removed the commit so that you can merge just the test changes. BTW - I wonder if I didn't introduce a "backwards incompatibility", i.e. whether buster.assert and others were there before 0.7.4 ? Anyway that turns out to be an issue I'm willing to fix this (by checking whether assert is available as a global or scoped under buster. and using what's available rather than making assumptions). |
Make tests compatible with BusterJS 0.7.4+
|
@kamilgrymuza thank you for your pull request! |
|
@mroderick you're welcome - I'm glad I could contribute a little :) |
|
Before publishing a new release, I'd like to improve things, so that we only require a local buster (which can be defined by package.json), so we won't run into this again. |
|
Sounds like a good idea - I think also PhantomJS could be local ? |
As of BusterJS 0.7.4 assert, refute and expect are no longer global which
breaks the test suite. Using buster.assert, buster.refute and buster.expect
solves the issue.