Initial work on unit tests, more coming soon

Author: mrodrig

package-lock.json

@@ -39,7 +39,7 @@
         "cli"
     ],
     "dependencies": {
-        "deeks": "2.4.0",
+        "deeks": "2.4.1",
         "doc-path": "3.0.0"
     },
     "devDependencies": {

package.json

@@ -40,7 +40,8 @@ const fs = require('fs'),
         {key: 'emptyLastFieldValue', file: '../data/csv/emptyLastFieldValue.csv'},
         {key: 'emptyLastFieldValueNoEol', file: '../data/csv/emptyLastFieldValueNoEol.csv'},
         {key: 'lastCharFieldDelimiter', file: '../data/csv/lastCharFieldDelimiter.csv'},
-        {key: 'nativeMapMethod', file: '../data/csv/nativeMapMethod.csv'}
+        {key: 'nativeMapMethod', file: '../data/csv/nativeMapMethod.csv'},
+        {key: 'nestedDotKeys', file: '../data/csv/nestedDotKeys.csv'}
     ];
 
 function readCsvFile(filePath) {

test/config/testCsvFilesList.js

@@ -30,5 +30,6 @@ module.exports = {
     firstColumnWrapCRLF: require('../data/json/firstColumnWrapCRLF.json'),
     emptyLastFieldValue: require('../data/json/emptyLastFieldValue.json'),
     emptyLastFieldValueNoEol: require('../data/json/emptyLastFieldValueNoEol.json'),
-    nativeMapMethod: require('../data/json/nativeMapMethod.json')
+    nativeMapMethod: require('../data/json/nativeMapMethod.json'),
+    nestedDotKeys: require('../data/json/nestedDotKeys.json')
 };

test/config/testJsonFilesList.js

@@ -198,6 +198,15 @@ function runTests(jsonTestData, csvTestData) {
                     done();
                 });
             });
+
+            // Test case for #184
+            it('should properly convert keys with escaped/nested dots in them', (done) => {
+                converter.csv2json(csvTestData.nestedDotKeys, (err, json) => {
+                    if (err) done(err);
+                    json.should.deepEqual(jsonTestData.nestedDotKeys);
+                    done();
+                });
+            });
         });
 
         describe('Error Handling', () => {

test/csv2json.js

@@ -0,0 +1,2 @@
+a\.a,a\.b.c\.d,a\.b.c,a\.b.c\.f,a.a,a.b,a.b\.c\.d,a.f.g\.h,a.f.g\.h\.k,a.f.h.l\.m\.n\.o\.p
+a,4,5,6,1,2,32,3,5,qrstuv

test/data/csv/nestedDotKeys.csv

@@ -0,0 +1,22 @@
+[
+    {
+        "a.a": "a",
+        "a.b": {
+            "c.d": 4,
+            "c": 5,
+            "c.f": 6
+        },
+        "a": {
+            "a": 1,
+            "b": 2,
+            "b.c.d": 32,
+            "f": {
+                "g.h": 3,
+                "g.h.k": 5,
+                "h": {
+                    "l.m.n.o.p": "qrstuv"
+                }
+            }
+        }
+    }
+]

test/data/json/nestedDotKeys.json

@@ -145,6 +145,15 @@ function runTests(jsonTestData, csvTestData) {
                     done();
                 });
             });
+
+            // Test case for #184
+            it('should properly handle keys with nested dots in them', (done) => {
+                converter.json2csv(jsonTestData.nestedDotKeys, (err, csv) => {
+                    if (err) done(err);
+                    csv.should.equal(csvTestData.nestedDotKeys);
+                    done();
+                });
+            });
         });
 
         describe('Error Handling', () => {