Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Last version (converting values with toLocaleString) issue with Numbers #66

Closed
arenoux opened this issue Mar 10, 2016 · 1 comment
Closed
Assignees
Labels
Milestone

Comments

@arenoux
Copy link

arenoux commented Mar 10, 2016

Hello.
The last update you made to convert values with .toLocaleString will break some existing code...

Although it could be interesting to convert values based on local, maybe you should not have release it as a simple patch (2.0.15)...

For example, if you try to convert the following JSON into CSV :

{
  key:"key",
  value:1000
}

Before 2.0.15, result was:

KEY,VALUE
key,1000

Since 2.0.15, we will obtain:

KEY,VALUE
key,1,000
@mrodrig
Copy link
Owner

mrodrig commented Mar 10, 2016

I apologize for the inconvenience this caused. I didn't see this on my Cloud9 development machine and therefore didn't realize that change would end up breaking the intended functionality. The change from #64 is reverted in 2.0.18 and I unpublished all versions containing the .toLocaleString() on NPM. Thank you for reporting this and sorry for the inconvenience.

@mrodrig mrodrig closed this as completed Mar 10, 2016
@mrodrig mrodrig added the bug label Mar 10, 2016
@mrodrig mrodrig self-assigned this Mar 10, 2016
@mrodrig mrodrig added this to the 2.0.18 milestone Mar 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants