Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

README - Simplify oh my zsh installation steps #3

Merged
merged 2 commits into from
Apr 29, 2021
Merged

README - Simplify oh my zsh installation steps #3

merged 2 commits into from
Apr 29, 2021

Conversation

brkn
Copy link
Contributor

@brkn brkn commented Apr 29, 2021 •
edited
Loading

  • Merged installation steps 1 and 2 to skip changing directory.
  • Added a diff representation of the .zshrc changes to do.

@brkn brkn changed the title Simplify oh my zsh installation steps README - Simplify oh my zsh installation steps Apr 29, 2021
mroth
mroth requested changes Apr 29, 2021
View reviewed changes
Copy link
Owner

@mroth mroth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, always appreciate documentation cleanups. One small change suggested (which was actually my error originally I believe!).

README.md Outdated Show resolved Hide resolved
@brkn @mroth
Add missing slash
872cece 
Co-authored-by: Matthew Rothenberg <mrothenberg@gmail.com>
@brkn brkn requested a review from mroth April 29, 2021 13:56
@mroth mroth merged commit dce3fd1 into mroth:master Apr 29, 2021
@brkn brkn deleted the patch-1 branch April 29, 2021 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroth mroth mroth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brkn @mroth