Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix use_frameworks! #191

Merged
merged 1 commit into from
May 27, 2024
Merged

Fix use_frameworks! #191

merged 1 commit into from
May 27, 2024

Conversation

focux
Copy link
Contributor

@focux focux commented May 23, 2024

If a project uses dynamic frameworks on iOS, projects that include this library will not compile. This PR fixes that issue.

Fixes #188

@iM-GeeKy

This comment was marked as spam.

@mrousavy
Copy link
Owner

Cool, thank you!

@mrousavy mrousavy merged commit 970db85 into mrousavy:master May 27, 2024
2 of 4 checks passed
@gjbadros
Copy link

Hmmm, I recently switched to use_frameworks and even with using this latest release, our build (of Gluroo -- Hi Marc!) gives:

  (/Users/greg/gp/gluroo/app/node_modules/react-native-blurhash/ios/BlurhashViewComponentView.mm:13:9)

  11 | #import <react/renderer/components/blurhash_codegen/RCTComponentViewHelpers.h>
  12 |
> 13 | #import "react_native_blurhash-Swift.h"
     |         ^ 'react_native_blurhash-Swift.h' file not found
  14 |
  15 | using namespace facebook::react;
  16 |

@focux
Copy link
Contributor Author

focux commented May 28, 2024 via email

@gjbadros
Copy link

I see the change in the BlurhashModule.mm file in my node_modules/react-native-blurhash/ installed package. But that header is nowhere in the directory. That file isn't getting generated by the build process for some reason. (I'm just trying the RN new architecture with Expo SDK 51 for the first time.)

@gjbadros
Copy link

Actually, I think it was upgrading to 2.x that broke my iOS build because Android build is broken too. Seems the same as #190

@iM-GeeKy
Copy link

@gjbadros I was able to build successfully on both platforms on the latest version using Expo 51, but that was without enabling the new architecture via the flag.

@mrousavy
Copy link
Owner

hey greg!

hmmm, so new arch breaks after this?

@gjbadros
Copy link

Yes, that's true for our build. I can confirm that upgrading to 2.x broke both builds with the new architecture turned on (adding "newArchEnabled": true to app.json's expo.plugins[].expo-build-properties for both android and ios.

I've also just confirmed that I can upgrade to 2.x without the new architecture and Expo SDK 51 and have the build complete (haven't tested yet really).

@elyobo
Copy link

elyobo commented Oct 31, 2024

Seeing the same failure to build with v2 and the new arch and use_frameworks as mentioned above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Can't build iOS
6 participants