Feature/store files #23
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
we're waiting for google/jsonapi to implement nested structs or to accept this PR google/jsonapi#99 We need nested structs for the upcoming mail endpoint
We have to format and parse addresses every time we store/read them from mysql. We could prevent this if we store them as json. Which is ugly. A better way is to store the whole mail/attachment as document. The addresses in to,cc and bcc stay easily accessible that way
we store mail content inside the db for now
We should be able to use the same bootstrap (db, queue, etc.) for the api and the workers.
remove everything uneccessary from worker and mailer
we had some recent API changes
# Conflicts: # cmd/styx-api/main.go # cmd/styx-worker/main.go # mailer/mailer.go # resource/resource_mail.go # storage/mail.go # storage/mail_status.go # worker/worker.go
Munsio
approved these changes
Sep 18, 2017
| defer styx.Close() | ||
|
|
||
| aHandler := handler.Attachment{Validator: styx.Validator, Service: styx.AttachmentService} | ||
| uHandler := handler.Upload{Service: styx.AttachmentService} |
There was a problem hiding this comment.
Ich finde das abkürzen echt kacke - des uHandler kann so viel heißen (User, Upload, Update...) bin ich da alleine?
cmd/styx-api/main.go
Outdated
| r.Handle("/mails", mHandler).Methods("POST") | ||
| r.Handle("/mails/{id}", mHandler).Methods("GET") | ||
| http.Handle("/", r) | ||
| log.Fatal(http.ListenAndServe(":9999", nil)) |
There was a problem hiding this comment.
Wir haben ja ein config file da würd ich den Port auslesen
handler/mail.go
Outdated
| "github.com/Slemgrim/styx/model" | ||
| "github.com/Slemgrim/styx/service" | ||
| "github.com/Slemgrim/jsonapi" | ||
| //"github.com/gorilla/mux" |
There was a problem hiding this comment.
bitte löschen wenns nicht mehr gebraucht wird
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.