Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thread lock #50

Closed
RoccoDevs opened this issue Jun 29, 2020 · 4 comments
Closed

Thread lock #50

RoccoDevs opened this issue Jun 29, 2020 · 4 comments

Comments

@RoccoDevs
Copy link

I made a simple search box that searches trough a list of some items. This code runs fairly fast (~1-2ms).
I added some console output to verify this, those outputs are shown in the chrome console instantly as I type.

And while the console instantly reflects what I type in the UI remains locked up and lags behind severely.
To make sure I removed all logic from my reducers and just returned the old state. This resulted in reducers that took less than a ms. However the result is the same.

Am I doing something wrong or is this a limit of the Fluxor framework?

private void OnSearchTextChanged(ChangeEventArgs e)
        {
            Dispatcher.Dispatch(new SearchInDossierListAction(e.Value.ToString()));
        }
@mpp
Copy link

mpp commented Jun 29, 2020

Hi, I had the same problem doing the same thing.

I didn't investigate it a lot as I have several different features with their states. I thought it was slow because of the size and complexity of the overall redux state:

image

Let me know if you find any solution!

@JefSchraag
Copy link

In my project, I could make it faster by disabling the dev tools

		.AddFluxor(options =>
				{
					options.ScanAssemblies(typeof(Program).Assembly);
					//options.UseRouting();
					//options.UseReduxDevTools();
				});

I have not checked but from the difference in performance, I concluded that the UseReduxDevTools is always serializing the state at every change.

@RoccoDevs
Copy link
Author

@JefSchraag Disabling it did solve it for me. So it seems like it's an issue with that indeed! Guess that'll just be a problem when debugging then.

@mrpmorris
Copy link
Owner

Redux Dev Tools is designed to accept the full state serialised as json. I don't think there is anything I can do about that except perhaps throttle updates when the same action type is dispatched.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants