Pullup not enabled on ESP32

[Jueff]

Enabling pullup for ExtIntPin fails with ESP32.
Seems that old way to enable pullup by writing a 1 to the port doesn't work with ESP.

Changed code from

  pinMode( ExtIntPinNum, INPUT );
  if( EnablePullup )
    digitalWrite(ExtIntPinNum, HIGH);

to
pinMode( ExtIntPinNum, EnablePullup ? INPUT_PULLUP : INPUT );

then it works.

[kiwi64ajs]

Hi Jueff, Good spotting, I’ve committed that change and released an update to 2.0.6 Alex

…

On 19/10/2020, at 8:19 AM, Jueff ***@***.***> wrote: Enabling pullup for ExtIntPin fails with ESP32. Seems that old way to enable pullup by writing a 1 to the port doesn't work with ESP. Changed code from if( EnablePullup ) digitalWrite(ExtIntPinNum, HIGH); to pinMode( ExtIntPinNum, EnablePullup ? INPUT_PULLUP : INPUT ); then it works. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#43>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AB5Y53N57OAZC5IFEXHWYYLSLM5VPANCNFSM4SVJAHIQ>.