Issue #21 - Memory leak #22
Conversation
…s from the PUT function before doing the CURL cleanups on lines 229 thru 231. This causes a memory leak.
I tested the following code change with the PUT function and it resolves the leak. I made changes in all functions that had similar code.
if (res != CURLE_OK)
{
ret.body = "Failed to query.";
ret.code = -1;
//return ret; //Commented the return
} else { //else added here
long http_code = 0;
curl_easy_getinfo(curl, CURLINFO_RESPONSE_CODE, &http_code);
ret.code = static_cast(http_code);
}
Functions now have only one return statement.
|
I looked at the failing checks and I don't believe they are related to the changes I made. |
|
@watsocd thank you so much for taking the time to contribute! The tests have had some problems which I was meaning to look into, so they are likely unrelated. I'll take a closer look at the changes in the coming days and will comment then. |
|
@watsocd I changed master to fix the tests. Would you mind to merge it so we can have the build succeed here? |
|
also this fixes #21, right? |
|
The one leak issue was already fixed. This second issue takes care of a second leak in the same code. I looked at the testing code. Are we positive the test server is functional? |
|
I am new to Github. It won't let me merge. It says: This branch is up-to-date with the base branch |
|
ah yea I meant merge master into your pull request branch. It should go something like this: Does that help? |
|
Looks like it passed now but I am not sure I did anything!! I am finding Git extremely confusing!! |
|
hmm that's interesting. Not sure why they pass now. It looks like your branch is still using the old test setup which should be completely defunct. But don't worry about that. Can you just merge in master and write a test to run all methods against a non-existing URL maybe so we can have tests running against this new functionality? |
|
@watsocd any updates on this? |
|
this should be fixed via #39 now |
This is my first contribution to an open source project and my first use of GitHub so if I did anything incorrectly, just delete this entire thing.
If the remote server does not respond to the HTTP request, line 223 (for example) returns from the PUT function before doing the CURL cleanups on lines 229 thru 231. This causes a memory leak.
I tested the following code change with the PUT function and it resolves the leak. I made changes in all functions that had similar code.
if (res != CURLE_OK)
{
ret.body = "Failed to query.";
ret.code = -1;
//return ret; //Commented the return
} else { //else added here
long http_code = 0;
curl_easy_getinfo(curl, CURLINFO_RESPONSE_CODE, &http_code);
ret.code = static_cast(http_code);
}
...Followed by CURL cleanup and return statement.
Functions now have only one return statement.