Headers #26
Merged
Headers #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| RestClient::headermap headers; | ||
| headers["If-Modified-Since"] = "Sat, 29 Oct 1994 19:43:31 GMT"; | ||
| RestClient::response res = RestClient::get("http://httpbin.org/cache", headers); | ||
| EXPECT_EQ(304, res.code); |
There was a problem hiding this comment.
can you change this code to run against the /headers endpoint and check the actual return body that the header was set properly? I think that makes for a much better test case and I have the hope that if postmanlabs/httpbin#248 gets fixed, we can extend the unit tests to the other methods.
|
Awesome, thanks so much for this contribution! I left one comment for improving the unit test, if you could fix that, I'll merge it. |
|
OK, I've fixed that. Please check it. |
|
@ksamborski awesome, thank you! Can you also merge the current master into your branch? The pull request seems to have a conflict right now. |
|
I've merged it. I hope it's fine now :) |
|
awesome! thank you! |
mrtazz
added a commit
that referenced
this pull request
Sep 6, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
I needed some headers support so I added it. Please check if it's fine or not with your idea.
Regards,
Karol