Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support to http basic auth #3

Merged
merged 1 commit into from
Jul 12, 2013
Merged

Adding support to http basic auth #3

merged 1 commit into from
Jul 12, 2013

Conversation

eriksson
Copy link
Contributor

@eriksson eriksson commented Sep 2, 2012

Adding support to http basic auth

@travisbot
Copy link

This pull request fails (merged a69728d into df8f0eb).

@mrtazz
Copy link
Owner

mrtazz commented Sep 3, 2012

This is really awesome, thanks for the Pull Request!

Unfortunately this needs a little bit of cleanup before I can merge it:

  • IDE specific files shouldn't be commited to the repository, same goes for object files and compiled libs
  • we don't need to include curl since the library should be installed by means of the OS package manager
  • the existing source code uses spaces. The introduction of tabs makes the diff very hard to read because the whole file changes apparently. Could you change it to use spaces also?

It also seems that the unit tests fail on that pull request. I'm not sure why yet. But it will be much easier to debug with a cleaner diff.

@ghost ghost assigned mrtazz Sep 25, 2012
@mrtazz
Copy link
Owner

mrtazz commented May 6, 2013

any updates on this?

@eriksson
Copy link
Contributor Author

I cleaned up the code. Hope it is ok now.

@mrtazz mrtazz merged commit 1ad99a3 into mrtazz:master Jul 12, 2013
@mrtazz
Copy link
Owner

mrtazz commented Jul 12, 2013

Awesome, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants