Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

progress/success indicator #5

Merged
merged 1 commit into from
Nov 27, 2022
Merged

Conversation

pookzilla
Copy link
Collaborator

Add simple progress indictor as a prefix for the profile label. Shows progress/success/failure of an executed command.
I've been seeing some sporadic failures in posting toots and this is a precursor to the actual fix as I haven't been able to catch it happening yet in the debugger. Eventually I'd like to add a status view that contains a record of previous commands and their reason for failure if available.

@@ -318,3 +326,94 @@ func (tuiCore *TUICore) ExitCommandMode(force bool) bool {

return false
}

var spinners = [...]string{"⠋", "⠙", "⠹", "⠸", "⠼", "⠴", "⠦", "⠧", "⠇", "⠏"}
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is the best option but I have no attachment either way if you wanna change.

Copy link
Owner

@mrusme mrusme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's cool! I remember having similar issues from time to time, which iirc were related to replies to toots. I believe the timeline sorting and assignment of IDs was to blame, but I'm not sure.

@mrusme mrusme added the enhancement New feature or request label Nov 27, 2022
@mrusme mrusme merged commit 079d9a5 into mrusme:master Nov 27, 2022
@pookzilla pookzilla deleted the progress-spinner branch November 27, 2022 13:41
@pookzilla
Copy link
Collaborator Author

That's cool! I remember having similar issues from time to time, which iirc were related to replies to toots. I believe the timeline sorting and assignment of IDs was to blame, but I'm not sure.

oh shoot ya I think you're right. Can't remember it ever happening for attempts that weren't replies.

@mrusme
Copy link
Owner

mrusme commented Nov 27, 2022

@pookzilla fyi, I've tagged a new version so that your recent changes become available to all the folks using gomphotherium! :-)

@pookzilla
Copy link
Collaborator Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants