Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use updated go-ses with aws4 signing, remove unnecessary method from … #2

Merged
merged 1 commit into from
Aug 7, 2020

Conversation

bserdar
Copy link
Contributor

@bserdar bserdar commented Aug 7, 2020

…asw interface

@codecov-commenter
Copy link

Codecov Report

Merging #2 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #2      +/-   ##
==========================================
+ Coverage   95.75%   95.77%   +0.01%     
==========================================
  Files           6        6              
  Lines         283      284       +1     
==========================================
+ Hits          271      272       +1     
  Misses          6        6              
  Partials        6        6              
Impacted Files Coverage Δ
aws_ses.go 95.00% <ø> (ø)
config.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d9c07b...8189fda. Read the comment docs.

Copy link
Owner

@mrz1836 mrz1836 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comment about the SendRawEmail vs SendEmail

aws_ses.go Show resolved Hide resolved
@mrz1836 mrz1836 self-assigned this Aug 7, 2020
@mrz1836 mrz1836 added the update General updates label Aug 7, 2020
@mrz1836 mrz1836 merged commit 94777b6 into mrz1836:master Aug 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
update General updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants