catch rookie mistakes with usage of website #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ms609
requested changes
Sep 26, 2017
Template.php
Outdated
| if ($this->blank('url') && !$this->blank('website')) { // No URL, but a website | ||
| $url = trim($this->get('website')); | ||
| if (strtolower(substr( $url, 0, 4 )) !== "http" ) { | ||
| $url = "https://" . $url; // Try it with http |
There was a problem hiding this comment.
Could we go a step further with a regexp to catch typos such as website = ttp:/web.com? (Might not be necessary in enough cases to justify)
Also is it worth testing http as well as https to catch sites that lack SSL?
Template.php
Outdated
| } | ||
| if (filter_var($url, FILTER_VALIDATE_URL,FILTER_FLAG_HOST_REQUIRED | FILTER_FLAG_PATH_REQUIRED ) ) { // is a valid http(s) URL with a full hostname and path of some type | ||
| $this->set('url',$url); | ||
| $this->forget('website'); |
There was a problem hiding this comment.
Rather than using "set" and "forget", it would be better to rename the existing parameter; this will preserve its position in the citation and its formatting/spacing.
also, there are bots that will convert http to https for some websites
|
I think this now much better. That regex is insane, but necessary if we are going to claim that a website is actually a URL. |
ms609
approved these changes
Sep 27, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.