-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Format journal names better #453
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GlazerMann
changed the title
Format titles betterdo not commit
Format journal names better
Jul 29, 2018
Check lowercase to Uppercase conversion too. Shouldn't `of` become `Of` if after a period?
Codecov Report
@@ Coverage Diff @@
## master #453 +/- ##
=============================================
- Coverage 83.73% 73.62% -10.12%
+ Complexity 1405 1404 -1
=============================================
Files 9 9
Lines 2392 2400 +8
=============================================
- Hits 2003 1767 -236
- Misses 389 633 +244
Continue to review full report at Codecov.
|
Non-journal title to confirm not covered by a specific exception. Use title to clarify expectation of test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
everything but periods for journal titles
BUT, it does periods if there are lots of them (J. Chem. Phys. Biol. Chem. Too. Many. A.)
And the words "an" "the" "a" if followed by a whitespace
And a single letter if at the end for things like "J of Chem. Phys. C"
renamed the variable passed in to match what it does
Resolves #452