Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format journal names better #453

Closed
wants to merge 17 commits into from
Closed

Format journal names better #453

wants to merge 17 commits into from

Conversation

GlazerMann
Copy link
Collaborator

@GlazerMann GlazerMann commented Jul 28, 2018

everything but periods for journal titles
BUT, it does periods if there are lots of them (J. Chem. Phys. Biol. Chem. Too. Many. A.)
And the words "an" "the" "a" if followed by a whitespace
And a single letter if at the end for things like "J of Chem. Phys. C"
renamed the variable passed in to match what it does
Resolves #452

@GlazerMann GlazerMann changed the title I think the regex is wrong Format titles better Jul 28, 2018
@GlazerMann GlazerMann changed the title Format titles better Format titles betterdo not commit Jul 29, 2018
@GlazerMann GlazerMann changed the title Format titles betterdo not commit Format journal names better Jul 29, 2018
Repository owner deleted a comment from codecov bot Jul 29, 2018
Check lowercase to Uppercase conversion too.  Shouldn't `of` become `Of` if after a period?
@codecov
Copy link

codecov bot commented Jul 29, 2018

Codecov Report

Merging #453 into master will decrease coverage by 10.11%.
The diff coverage is 100%.

Impacted file tree graph

@@              Coverage Diff              @@
##             master     #453       +/-   ##
=============================================
- Coverage     83.73%   73.62%   -10.12%     
+ Complexity     1405     1404        -1     
=============================================
  Files             9        9               
  Lines          2392     2400        +8     
=============================================
- Hits           2003     1767      -236     
- Misses          389      633      +244
Impacted Files Coverage Δ Complexity Δ
expandFns.php 97.41% <100%> (+0.06%) 0 <0> (ø) ⬇️
WikipediaBot.php 0% <0%> (-66.81%) 87% <0%> (ø)
Page.php 63.26% <0%> (-19.05%) 51% <0%> (ø)
Template.php 81.44% <0%> (-3.28%) 1252% <0%> (-1%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c5656c0...60d5a92. Read the comment docs.

Martin R. Smith and others added 5 commits July 29, 2018 17:18
Non-journal title to confirm not covered by a specific exception.
Use title to clarify expectation of test.
@GlazerMann GlazerMann closed this Aug 1, 2018
@GlazerMann GlazerMann deleted the patch-11 branch August 11, 2018 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant