Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix get_identifiers_from_url() return codes #517

Closed
wants to merge 4 commits into from
Closed

Fix get_identifiers_from_url() return codes #517

wants to merge 4 commits into from

Conversation

GlazerMann
Copy link
Collaborator

@GlazerMann GlazerMann commented Aug 7, 2018

The get_identifiers_from_url() return code is ONLY checked when adding a new URL in add_if_new().

Current code returns TRUE if the URL was converted into something else.
Proposed code also returns TRUE if the URL could have been converted, but the item already existed.
As it is code could add handle url for example even if hdl= was already set.

@codecov
Copy link

codecov bot commented Aug 7, 2018

Codecov Report

Merging #517 into master will decrease coverage by 2.95%.
The diff coverage is 50%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #517      +/-   ##
============================================
- Coverage     75.73%   72.77%   -2.96%     
- Complexity     1433     1449      +16     
============================================
  Files             9        9              
  Lines          2464     2490      +26     
============================================
- Hits           1866     1812      -54     
- Misses          598      678      +80
Impacted Files Coverage Δ Complexity Δ
Template.php 79.65% <50%> (-4.22%) 1297 <0> (+16)
expandFns.php 95.16% <0%> (+0.11%) 0% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a2fcec1...e32abdb. Read the comment docs.

@GlazerMann GlazerMann closed this Aug 8, 2018
@GlazerMann GlazerMann reopened this Aug 8, 2018
@GlazerMann GlazerMann changed the title data from url return codes Fix get_identifiers_from_url() return codes Aug 10, 2018
@GlazerMann GlazerMann closed this Aug 11, 2018
@GlazerMann GlazerMann deleted the patch-29 branch August 11, 2018 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant