Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cite Arxiv does not support bibcode #717

Merged
merged 3 commits into from
Sep 18, 2018
Merged

Cite Arxiv does not support bibcode #717

merged 3 commits into from
Sep 18, 2018

Conversation

GlazerMann
Copy link
Collaborator

@GlazerMann GlazerMann commented Sep 3, 2018

This has to be done in final tidy since bibcode might lead to doi pmid etc

@codecov
Copy link

codecov bot commented Sep 3, 2018

Codecov Report

Merging #717 into master will decrease coverage by 1.57%.
The diff coverage is 50%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #717      +/-   ##
============================================
- Coverage     70.09%   68.51%   -1.58%     
- Complexity     1638     1640       +2     
============================================
  Files            12       12              
  Lines          3320     3322       +2     
============================================
- Hits           2327     2276      -51     
- Misses          993     1046      +53
Impacted Files Coverage Δ Complexity Δ
Template.php 73.81% <50%> (-2.57%) 1460 <0> (+2)
expandFns.php 90.97% <0%> (+0.69%) 0% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3bc60b0...0137d4c. Read the comment docs.

ms609
ms609 previously requested changes Sep 11, 2018
Copy link
Owner

@ms609 ms609 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a test please?

@ms609 ms609 merged commit 10d0261 into ms609:master Sep 18, 2018
@GlazerMann GlazerMann deleted the patch-26 branch September 18, 2018 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants